Dev Tools Interest Group Joining Doesn't Show Priority Related Elements #1042
Assignees
Comments
|
@brusshamilton what do you think of changing this to just be an object in devtools and have a blink::InterestGroup::SerializeForDevtools the way I did for AuctionConfig? |
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Mar 12, 2024
... to match how AuctionConfig works, and add in missing fields. Basically, instead of having a detailed type in devtools protocol --- which frontend didn't really make any use of, it just JSONifies the value --- have it as `object` and fill in a base::Value::Dict ourselves. Fixes WICG/turtledove#1042 Change-Id: I9e2cd5d8857c404d6333f20509bb3e65968a554b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340990 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/main@{#1271547}
|
Should be fixed as of 124.0.6355.0 canary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Dev Tools --> Application --> Interest Group pane doesn't show fields like:
The code that created the IG looks like this:
var interestGroup = { owner: 'https://www.pst-dsp.com', name:InterestGroupabc, priorityVector: { signalA: 1 }, prioritySignalsOverrides: { signalA: 1 }, enableBiddingSignalsPrioritization: 1, priority: 10, lifetimeMs: 1000 * 60 * 60 * 24 * 30, ads: [], biddingLogicUrl: 'https://www.pst-dsp.com/bidding.js' }; await navigator.joinAdInterestGroup(interestGroup);Here is the Dev Tools values displayed, w/o priority fields:
And here we see the expected db values, indicating it was correctly joined.
Also demo here.
This is minor, would be good as part of general introspection, debugging, etc.
The text was updated successfully, but these errors were encountered: