Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing the limit on interest group size? #402

Open
jonasz opened this issue Nov 29, 2022 · 10 comments
Open

Increasing the limit on interest group size? #402

jonasz opened this issue Nov 29, 2022 · 10 comments
Labels
Non-breaking Feature Request Feature request for functionality unlikely to break backwards compatibility

Comments

@jonasz
Copy link
Contributor

jonasz commented Nov 29, 2022

Hi,

Currently there is a limit of 50kB on the size of a single interest group. We are considering, for various reasons, adjusting our system to only create a single IG per advertiser. By doing so we'd need to squeeze in more information in a single IG instance, and the 50kB limit becomes problematic.

I was wondering, would it be possible to increase the limit? Or perhaps to introduce a single limit for the total size of all interet groups created on a specific domain by a specific owner, and drop the per-IG 50kB limit?

Best regards,
Jonasz

@stguav
Copy link

stguav commented Nov 29, 2022

We are also interested in this direction, depending on how some of the issues mentioned in #361 get addressed.

@dmdabbs
Copy link
Contributor

dmdabbs commented Nov 29, 2022

I didn't find a 50kB limit. Would you mind referring me to it? TY

@jonasz
Copy link
Contributor Author

jonasz commented Nov 30, 2022

Hi David, you can find it here https://wicg.github.io/turtledove/spec.html#joining-interest-groups if you search for "50 KB".

@dmdabbs
Copy link
Contributor

dmdabbs commented Nov 30, 2022

Thank you @jonasz. If the proposed sellerCapabilities (née approvedSellers) field for granting per-buyer latency/stats reporting permission is added to the 'budget' we will need even more headroom. Surely there is another more flexible means for buyers to grant these perms that does not burden every addInterestGroup registration.

@caraitto
Copy link
Collaborator

caraitto commented Dec 7, 2022

I think we can consider something like @jonasz proposed -- a per joining origin / site limit across all interest groups joined from that origin / site. We'd still need a global limit, since the number of origins / sites that a user can visit is arbitrarily large.

What new limit values would work for you?

@jonasz
Copy link
Contributor Author

jonasz commented Dec 14, 2022

What do you think about 5MB per (owner, site), and 50MB per (owner)? These should be comfortable limits for us judging by our current usage and estimates.

@gianni-99
Copy link

That could work for us too. We would like to revisit the numbers once we get more FLEDGE traffic.

@brusshamilton
Copy link
Contributor

We're looking into increasing the per-interest group limit to 1MB, with a limit of 10MB per owner. Does that sound like it would be sufficient for your use cases?
The size of interest groups plays a role in auction latency since they need to be read from disk, deserialized, sent across processes, and loaded into v8. All of these delays increase with the size of the interest group, and the disk read and deserialization need to happen even if the interest group doesn't bid.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 11, 2023
Also set a per-owner limit of 10MB for all interest groups from that
owner.

Related to discussion: WICG/turtledove#402

Change-Id: I01ae54e2f41e1c24d93f9abe5630d7bdd18a3a83
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 11, 2023
Also set a per-owner limit of 10MB for all interest groups from that
owner.

Related to discussion: WICG/turtledove#402

Change-Id: I01ae54e2f41e1c24d93f9abe5630d7bdd18a3a83
aarongable pushed a commit to chromium/chromium that referenced this issue Apr 12, 2023
Also set a per-owner limit of 10MB for all interest groups from that
owner.

Related to discussion: WICG/turtledove#402

Change-Id: I01ae54e2f41e1c24d93f9abe5630d7bdd18a3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362860
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1129232}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 12, 2023
Also set a per-owner limit of 10MB for all interest groups from that
owner.

Related to discussion: WICG/turtledove#402

Change-Id: I01ae54e2f41e1c24d93f9abe5630d7bdd18a3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362860
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1129232}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 12, 2023
Also set a per-owner limit of 10MB for all interest groups from that
owner.

Related to discussion: WICG/turtledove#402

Change-Id: I01ae54e2f41e1c24d93f9abe5630d7bdd18a3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362860
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1129232}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 18, 2023
…1MB, a=testonly

Automatic update from web-platform-tests
Increase maximum interest group size to 1MB

Also set a per-owner limit of 10MB for all interest groups from that
owner.

Related to discussion: WICG/turtledove#402

Change-Id: I01ae54e2f41e1c24d93f9abe5630d7bdd18a3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362860
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1129232}

--

wpt-commits: eae9862859a94faccc2abbf87e6b718408c85b41
wpt-pr: 39483
@JensenPaul JensenPaul added the Non-breaking Feature Request Feature request for functionality unlikely to break backwards compatibility label Jun 22, 2023
@brusshamilton
Copy link
Contributor

Circling back to this, we increased the per-interest group size limit to 1MB, with a limit of 10MB per owner. That change rolled out in Chrome release M114.

@davideanastasia
Copy link

If a publishers is hosting -- for instance -- 10 interest group owners, would that equate to process 100Mb of data for each runAdAuction in the worst case scenario?
If that's the case -- please correct me if I am on the wrong track -- that could easily lead to extreme high CPU usage from the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking Feature Request Feature request for functionality unlikely to break backwards compatibility
Projects
None yet
Development

No branches or pull requests

8 participants