Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "join-ad-interest-group" & "run-ad-auction" default allowlists to self #522

Open
miketaylr opened this issue Apr 7, 2023 · 3 comments
Labels
compat concern likely to be a breaking change for developers

Comments

@miketaylr
Copy link
Collaborator

Currently they're *.

@JensenPaul
Copy link
Collaborator

@miketaylr miketaylr changed the title Consider moving "join-ad-interest-group" & "run-ad-auction" default allowlists to self Move "join-ad-interest-group" & "run-ad-auction" default allowlists to self Apr 7, 2023
@JensenPaul JensenPaul added the compat concern likely to be a breaking change for developers label Jun 27, 2023
@JensenPaul
Copy link
Collaborator

Changing to default the allowlists to self has been our long term plan but we've heard feedback that it blocks adoption and usability at this stage, especially in the long-tail of advertisers. Providing a solution to audience stealing is an important goal of Protected Audience. Our current implementation offers opt-in protection via our Permission-Policy, and we're going to continue to look for an ergonomic solution that facilitates adoption sufficiently to offer the protection by default.

@thegreatfatzby
Copy link
Contributor

Hey @JensenPaul ended up circling back to this and have a couple of questions:

  • Is there any timeline on when the default allowlists will be changed? I don't think I'm seeing one here.
  • Is the correct way to explicitly specify the allow-list of *, so that your code can be "explicitly correct", like so: "join-ad-interest-group *; run-ad-interest-group: "? When I do that I'm still getting the warning below, although it seems to join fine (I did try '', all, and 'all', but got an invalid origin error that borked everything).

In the future, Permissions Policy feature run-ad-auction will not be enabled by default in cross-origin iframes or same-origin iframes nested in cross-origin iframes. Calling runAdAuction will be rejected with NotAllowedError if it is not explicitly enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat concern likely to be a breaking change for developers
Projects
None yet
Development

No branches or pull requests

3 participants