Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting leaveAdInterestGroup from ad component frames from M120 #879

Merged
merged 6 commits into from Jan 8, 2024
+1 −1
Merged

Supporting leaveAdInterestGroup from ad component frames from M120 #879

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22d636b
Enable leaveAdInterestGroup from ad component frames from M120
xiaochen-z Oct 24, 2023
6961c78
Merge branch 'WICG:main' into leave_interest_group_from_ad_components
xiaochen-z Oct 25, 2023
ea74499
Add more comments.
xiaochen-z Oct 25, 2023
79911db
Fixed typos.
xiaochen-z Oct 25, 2023
2a45566
Link to ad component definition
xiaochen-z Nov 2, 2023
860a153
Fixed typo.
xiaochen-z Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion FLEDGE.md
View file
Open in desktop
Expand Up @@ -132,7 +132,7 @@ The browser will only allow the `joinAdInterestGroup()` operation with the permi

The returned `joinPromise` is resolved if the group is successfully joined, and rejected with an error if the join operation fails. The error message and the resolution time must _not_ depend on what interest groups a user is in, or any cross-origin browser state, apart from the results of the .well-known fetch, to avoid leaking any data across sites.

There is a complementary API `navigator.leaveAdInterestGroup(myGroup)` which looks only at `myGroup.name` and `myGroup.owner`. As with join calls, `leaveAdInterestGroup()` also returns a promise. As a special case to support in-ad UIs, invoking `navigator.leaveAdInterestGroup()` from inside an ad that is being targeted at a particular interest group will cause the browser to leave that group, irrespective of permission policies. Note that calling `navigator.leaveAdInterestGroup()` without arguments isn't supported inside a component ad frame.
xiaochen-z marked this conversation as resolved.
Show resolved Hide resolved
There is a complementary API `navigator.leaveAdInterestGroup(myGroup)` which looks only at `myGroup.name` and `myGroup.owner`. As with join calls, `leaveAdInterestGroup()` also returns a promise. As a special case to support in-ad UIs, invoking `navigator.leaveAdInterestGroup()` from inside an ad that is being targeted at a particular interest group will cause the browser to leave that group, irrespective of permission policies. Note that calling `navigator.leaveAdInterestGroup()` without arguments inside a [component ad](https://github.com/WICG/turtledove/blob/main/FLEDGE.md#34-ads-composed-of-multiple-pieces) frame isn't supported until Chrome M120. Starting from Chrome M120, calling `navigator.leaveAdInterestGroup()` without arguments inside a component ad frame is supported. The ad component frame is required to be same-origin with the interest group owner for the leave to succeed, same as calling `leaveAdInterestGroup()` without arugments in a non-ad-component frame.
xiaochen-z marked this conversation as resolved.
Show resolved Hide resolved

There is a related API `navigator.clearOriginJoinedAdInterestGroups(owner, [<groupNamesToKeep>])` that leaves all interest groups owned by `owner` that were joined on the current top-level frame's origin, and also returns a Promise. The `[<groupNamesToKeep>]` argument is an optional list of interest group names that will not be left, and if not present, it will act as if an empty array was passed. This method has no effect on joined interest groups owned by `owner` that were most recently joined on different top-level origins.

Expand Down