Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explainer for cross-document navigations #208
Add explainer for cross-document navigations #208
Changes from 3 commits
882e300
d7e23ca
a4a2287
cd99d1f
7afcb31
2e4d581
09b1a2e
315228c
7a42f7c
97afd0e
7029566
145130a
37aaf6c
2944230
b942ab7
0fafa8d
ed09fa0
88f82ec
27af442
27774b9
fdb42e9
b46716a
93681bc
4fdf0c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Exit transition" was commonly used to refer to the animation done on an element which is leaving the screen. Just to avoid the confusion there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding an example of this? The most common one would be naming one of the elements in the list whose details page the user is navigating to. Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
pagehide
guaranteed to be before the new Document is created? It would be awkward for the old Document to skip the transition in this event if the new Document has already accessed it via document.activeTransition?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's guaranteed!