This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8 by allowing to set one-time properties like
container, layout, newChildFn
, etc only through the constructor.Addresses #12 by removing
Fn
suffix fromnewChild/updateChild/recycleChild
Initializing
VirtualRepeater
requires passing at minimum{container, newChild}
in the configInitializing
VirtualList
requires passing at minimum{container, layout, newChild}
It is still possible to extend both and override any of these configs by overriding either the
container, layout
setters or the child creation methods, e.g.Custom elements examples have been updated to keep an internal repeater/list instance instead of using the mixins. They forward the setting of public properties to the internal repeater/list e.g.
num, first, items
.