Replace appmanifest's launch algorithm with one that has launch_handler behaviors #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilligers
approved these changes
Oct 31, 2022
|
I'll wait for w3c/manifest#1056 to land before merging this one. |
fallaciousreasoning
approved these changes
Oct 31, 2022
alancutter
force-pushed
the
replace-launch-algorithm
branch
from
14e47ab
to
7444e95
Compare
alancutter
force-pushed
the
replace-launch-algorithm
branch
from
cd6973a
to
ae60cda
Compare
|
The manifest exports need a bit of time to propagate through, will hold off landing until then to make sure the xrefs work correctly. |
|
The red squiggles remaining will be fixed after w3c/manifest#1062 lands and the xrefs have time to propagate through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67 #69 #84
This builds on top of w3c/manifest#1056 which adds a
launch web applicationalgorithm to the manifest spec. This updates the launch handler spec to replace that algorithm with its own. This enables other webapp specs (not in WICG) to gain the launch_handler behaviour without directly referencing this WICG spec.Additionally this replaces the concept of "web app launch client" with the existing "application context" concept from the manifest spec which is effectively the same thing.