Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[active encoder config]] may be incorrect when running the Output EncodedVideoChunk algorithm. #138

Open
chcunningham opened this issue Feb 10, 2021 · 1 comment
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior

Comments

@chcunningham
Copy link
Collaborator

As of #113, The Output EncodedVideoChunk algorithm specifies that parts of the output config are to be copied from the "active encoder config". But the spec doesn't guarantee that the "active encoder config" was actually used to encode the given output (as opposed to some earlier config).

One fix is to specify that videoEncoder.configure() must flush all pending outputs before applying the new configuration. This is a little heavy though - we don't really want to require UAs to flush in this way (even though chromium currently does). There are some scenarios where the pipeline may be fairly deep and the configuration change fairly small such that a flush is not required and inefficient. I think a flush may not actually be observable though (as the running the configure control message is not observable), so maybe it leaves implementers the option to pursue equivalent alternatives.

Another fix is just to write out in english (rather than in algorithm steps) how the emitted VideoDecoderConfig is to be populated.

@chcunningham chcunningham added the editorial changes to wording, grammar, etc that don't modify the intended behavior label May 12, 2021
@chcunningham
Copy link
Collaborator Author

Triage note: marking 'editorial', as the task is just to wordsmith this to perfectly reflect the agreed upon intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior
Projects
None yet
Development

No branches or pull requests

1 participant