Require cofactorless (unbatched) verification equation for EdDSA #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiss
force-pushed
the
require-unbatched-equation
branch
from
3dd7b71
to
3f752f3
Compare
javifernandez
approved these changes
Feb 19, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 19, 2024
SHA: 067671c Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #19 by mandating the use of the cofactorless (unbatched) verification equation in Ed25519 and Ed448.
According to #19 (comment) and web-platform-tests/wpt#43751 (comment), this is already the current behavior of OpenSSL, BoringSSL, and Apple's CryptoKit. Hopefully this is true for other implementations as well, but let me know if there are any objections, of course.
Additionally, since Web Crypto does not have an API for batch signature verification, there seems to be no reason to use the cofactored (batched) equation.
By mandating one of the two equations, we reduce the risk of interoperability failures, as well as the risk of this (potential) difference being used to fingerprint implementations.
Preview | Diff