-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable mechanics not quite correct... #20
Comments
@sublimator wrote: While we are on the subject, the concept of a Maybe one tag with key/vals encoded would be nicer ? |
At least with the current implementation, we throw an error when more than one detected.
Do you have a link to an example of what you mean by that ? |
Good points. I'm not averse to it being a link element rather than meta, especially if that means the parsing used by manifest and how CSS deals with stylesheets being dynamically added/removed can be re-used. With a browser-vendor hat on, anything that allows re-use of code (or at least, doesn't require another mental model) lowers the barrier to adoption. |
Also other things... like demanding the tags only be in the |
Just following up... generally, we want to avoid dictating things in the spec, like:
We instead need to write all this as a parsing algorithm. We can look at how Web Manifest deals with finding |
Not sure what throwing an error means in this context? Like a JS error at the global object?
Ok, this is an extreme example... sorta, but we basically need to hook into: And getting more specific, here is how we would hook into processing/fetching the particular link relationship: (if we go down the Similarly with |
Actually, while I was tracking down some info for #23 I found out that initially @sharafian proposed one tag with a query string encoding key/vals. |
Doesn’t mean much more than only one stream at a time will be active. Any |
Awesome, thanks the info :) |
Depends on #19 |
Was going to edit these comments and put in the original authors but it seems it is sending email notifications ... |
From web-monetization created by marcoscaceres: adrianhopebailie/web-monetization#16
@marcoscaceres wrote:
The spec talks about observing the
head
for inclusions of the particular meta tag... we probably need to rewrite all this to align more with how the HTML parser works.There are also conflicting requirements.... like it says, "there MUST only be 1 meta tag", but it doesn't say what happens if there are two or more. Which one wins? Is the whole thing invalid? We should clarify that a bit more.
The text was updated successfully, but these errors were encountered: