Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Avoid mutating (signedexchange.Exchange).Payload #431

Open
nyaxt opened this issue May 3, 2019 · 0 comments
Open

Go: Avoid mutating (signedexchange.Exchange).Payload #431

nyaxt opened this issue May 3, 2019 · 0 comments
Assignees
Labels

Comments

@nyaxt
Copy link
Collaborator

nyaxt commented May 3, 2019

cc: @twifkak

In the current code, the Payload []byte field may contain payload either before or after mice encoding.
This is confusing behavior and we should avoid.

Perhaps we should factor out other Exchange members to a separate struct.
#427 would also benefit from such change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants