go: Split SignWithIntegrityBlock to be usable without flags #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards being able to use the tooling with one's own signing strategy without being forced to use it as a CMD tool with flags. With this change one can create their own wrapper Golang tool with their own ISigningStrategy implementation and pass their input and output files without being forced to use flags. The tool does not support providing the bytes directly as that would then limit the size of the web bundle into the max size of []byte array.
sonkkeli
deleted the
refactor-golang-sign-function-to-separate-flag-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards being able to use the tooling with one's own signing strategy without being forced to use it as a CMD tool with flags. With this change one can create their own wrapper Golang tool with their own ISigningStrategy implementation and pass their input and output files without being forced to use flags.
The tool does not support providing the bytes directly as that would then limit the size of the web bundle into the max size of []byte array.