Usability enhancements #18
Conversation
|
@jrannoni are you taking over maintenance on this package? It would be good to get this merged into |
|
Hey @petebachant, My apologies for the delay in getting this into FLORIS. We are planning to merge your changes, but I have a few things to add. Look out for a pull request to your fork and we can work together on getting to a good place with these improvements. |
|
Sounds good. Feel free to request changes from me here as well. |
floris/farm.py
Outdated
| turbine_dict = {} | ||
| for c in list(zip(self.layout_x, self.layout_y)): | ||
| turbine_dict[Coordinate(c[0], c[1])] = copy.deepcopy(turbine) | ||
| self.turbine_map = TurbineMap(turbine_dict) | ||
|
|
||
| self.turbine = turbine |
There was a problem hiding this comment.
why assign a particular turbine to the farm class?
There was a problem hiding this comment.
Good question! I need to see which commit put that in there.
Mostly formatting updates
|
I think the notebooks will need to be updated for the longer module names. |
|
ah yes, I'll do that |
Update jupyter notebooks after module name changes
|
Alright, we may be good to go! |
|
Thanks for taking the time to do this @petebachant |
I've made a bunch of changes to make FLORIS easier to use for my work. Resolves #13, supersedes #16 and #17.