Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #131

Merged
merged 7 commits into from
Jul 12, 2021
Merged

Fix tests #131

merged 7 commits into from
Jul 12, 2021

Conversation

gbarter
Copy link
Member

@gbarter gbarter commented Jul 9, 2021

Purpose

Fixes at least one of the failed tests and raises an Exception if OpenFAST fails for easier testing.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gbarter gbarter requested a review from dzalkind July 9, 2021 18:16
@gbarter gbarter changed the base branch from master to develop July 9, 2021 18:16
@gbarter
Copy link
Member Author

gbarter commented Jul 9, 2021

@rafmudaf : I am changing how errors are handled in the OpenFAST library wrapper by raising Exceptions instead or just printing. Do you want me to fork and submit a PR to your personal openfast fork? If so, which branch? OpenFAST dev?

dzalkind and others added 3 commits July 9, 2021 16:04
- Use PotMod = 1, remove from always being set in LinearFAST
- Reset PotFile path to WEIS dir if necessary
@gbarter
Copy link
Member Author

gbarter commented Jul 10, 2021

@dzalkind : When you get a chance on Monday, I could use your help fixing this test:
https://github.com/WISDEM/WEIS/blob/fix_tests/weis/aeroelasticse/test/test_OF_utils.py#L64

I am getting this error:

OpenFAST-v0.1-949-g895ce46d-dirty
 Compile Info:
  - Compiler: GCC version 9.3.0
  - Architecture: 64 bit
  - Precision: single
  - OpenMP: No
  - Date: Jul  9 2021
  - Time: 21:29:32
 Execution Info:
  - Date: 07/09/2021
  - Time: 22:05:52-0600

 OpenFAST input file heading:
     Generated with AeroElasticSE FAST driver

 Running ElastoDyn.
 Nodal outputs section of ElastoDyn input file not found or improperly formatted.
 Running AeroDyn.
 AD15 Nodal Outputs: Nodal output section of AeroDyn input file not found or improperly formatted.
 Skipping nodal outputs.
 Running InflowWind.
 Running ServoDyn.
  Time: 0 of 6 seconds.

 Unable to find steady-state solution.

 OpenFAST encountered an error at simulation time 6 of 6 seconds.
  Simulation error level: FATAL ERROR

  Aborting OpenFAST.

gbarter and others added 2 commits July 10, 2021 12:43
- separate case writing, generation, fix typo
- allow stdout in subprocess call
- speed up test
@rafmudaf
Copy link
Collaborator

@rafmudaf : I am changing how errors are handled in the OpenFAST library wrapper by raising Exceptions instead or just printing. Do you want me to fork and submit a PR to your personal openfast fork? If so, which branch? OpenFAST dev?

Either a pull request to my fork's feature/python_driver branch or I can cherry-pick the commits.

@gbarter gbarter merged commit 2b1efea into develop Jul 12, 2021
@gbarter gbarter deleted the fix_tests branch July 12, 2021 16:43
@rafmudaf
Copy link
Collaborator

@gbarter The OpenFAST change is well contained, so I'll just copy it over.

@gbarter
Copy link
Member Author

gbarter commented Jul 12, 2021

Thank you, Raf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants