Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to python-based precomp and correct specious airfoil rotations #522

Merged
merged 14 commits into from
Apr 29, 2024

Conversation

gbarter
Copy link
Member

@gbarter gbarter commented Apr 27, 2024

Purpose

This should solve both some of the windows Fortran frustrations in #505, by porting precomp to python, and the well-intentioned but ultimately specious airfoil rotations noted in #388.

The precomp code is broken out into its own submodule, instead of all being squashed into a single file under RotorSE.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gbarter gbarter merged commit 880bc2d into develop Apr 29, 2024
14 checks passed
@gbarter gbarter deleted the pyprecomp branch April 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants