Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WISEWebSocketHandler.java #1001

Closed
hirokiterashima opened this issue Nov 10, 2017 · 0 comments
Closed

Refactor WISEWebSocketHandler.java #1001

hirokiterashima opened this issue Nov 10, 2017 · 0 comments
Assignees
@hirokiterashima
Labels
Improvement
Projects
Portal
Milestone
v5.7 Major Release

Comments

@hirokiterashima
Copy link
Member

Description

  1. Replace isTeacher(user) and isStudent(user) methods and replace with user.isTeacher() and user.isStudent() calls
  2. getFirstName(user), getLastName(user) and getUserName(user) should not need to check for instance of StudentUserDetails or TeacherUserDetails because they're the only available options and both have those fields.
  3. Remove unused variables and code
  4. Remove redundant comments
@hirokiterashima hirokiterashima added this to the v5.7 Major Release milestone Nov 10, 2017
@hirokiterashima hirokiterashima self-assigned this Nov 10, 2017
hirokiterashima added a commit that referenced this issue Nov 11, 2017
@hirokiterashima
Removed WebSockerHandler.isStudentUser and isTeacherUser. #1001.
f16958b
hirokiterashima added a commit that referenced this issue Nov 11, 2017
@hirokiterashima
Removed checking for instance of teacher or student user details. #1001
7570d55
hirokiterashima added a commit that referenced this issue Nov 11, 2017
@hirokiterashima
Refactored WebSocketHander.onOpen method by removing unnecessary null…
e3a1af1 
… checks and redundant posting of online students to teacher. Also removed unused method and comments. #1001.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirokiterashima hirokiterashima

Labels
Improvement
Projects
No open projects
Portal
  
Awaiting triage
Milestone
v5.7 Major Release
Development

No branches or pull requests
1 participant
@hirokiterashima