Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPC teaser landing page #54

Merged
merged 10 commits into from
Apr 3, 2024
Merged

FPC teaser landing page #54

merged 10 commits into from
Apr 3, 2024

Conversation

maartenweyns
Copy link
Member

No description provided.

mpsijm
mpsijm reviewed Apr 3, 2024
View reviewed changes
static/fpc/teaser/index.html Outdated Show resolved Hide resolved
static/fpc/teaser/index.html Outdated Show resolved Hide resolved
static/fpc/style.css Outdated Show resolved Hide resolved
mpsijm
mpsijm approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@mpsijm mpsijm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the teaser is ready to go, do you have a reason for keeping the draft status other than that we don't know the exact location/time yet for the intro session? In my opinion, we can merge it like this and add these details later 🙂

@maartenweyns
Copy link
Member Author

I think the teaser is ready to go, do you have a reason for keeping the draft status other than that we don't know the exact location/time yet for the intro session? In my opinion, we can merge it like this and add these details later 🙂

Yeah, I was able to confirm the date with Verwoerd on Slack. Just a link to the page on events, but that can indeed be added later. I'll merge this PR.

@maartenweyns
Copy link
Member Author

Force push 😮

@maartenweyns maartenweyns marked this pull request as ready for review April 3, 2024 20:40
@maartenweyns maartenweyns merged commit c47d077 into main Apr 3, 2024
1 check passed
@maartenweyns maartenweyns deleted the teaser-fpc24-update branch April 3, 2024 20:41
@mpsijm
Copy link
Contributor

mpsijm commented Apr 3, 2024

Force pushing development branches is fine, you can't really get around that when you rebase 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpsijm mpsijm mpsijm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maartenweyns @mpsijm