Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwargs updates #70

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Kwargs updates #70

merged 2 commits into from
Jul 25, 2023

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Jul 25, 2023

Dimension plotter kwargs bug

Description

  • Replaced **kwargs in dimension_plotter with reducer_params and scatter_params to enable users to supply kwargs separately to the chosen reducer and the underlying seaborn.heatmap.

Fixes #68

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran pytest to check changes do not break the unit tests
  • Added new tests to check that the keyword argument reducer_params works with the dimension_plotter object.

Test Configuration:

  • Python version: 3.9
  • Operating System: WSL2(Ubuntu)

Reviewers

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #70 (3eba22b) into main (026ee70) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   90.17%   90.34%   +0.17%     
==========================================
  Files           9        9              
  Lines         845      860      +15     
==========================================
+ Hits          762      777      +15     
  Misses         83       83              
Files Changed Coverage Δ
src/elementembeddings/plotter.py 100.00% <100.00%> (ø)
src/elementembeddings/tests/test_plotter.py 100.00% <100.00%> (ø)

@AntObi AntObi merged commit f85b608 into main Jul 25, 2023
12 checks passed
@AntObi AntObi deleted the kwargs_updates branch July 25, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kwargs updates
1 participant