Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates #84

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Doc updates #84

merged 7 commits into from
Aug 7, 2023

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Aug 7, 2023

Pull Request Template

Description

  • Documentation updates
  • Removed deprecated functions

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran test suite

Test Configuration:

  • Python version: 3.9
  • Operating System: WSL2(Ubuntu)

Reviewers

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #84 (858d10f) into main (fb2e072) will increase coverage by 3.79%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   90.62%   94.41%   +3.79%     
==========================================
  Files           9        9              
  Lines         896      824      -72     
==========================================
- Hits          812      778      -34     
+ Misses         84       46      -38     
Files Changed Coverage Δ
src/elementembeddings/tests/test_core.py 100.00% <ø> (ø)
src/elementembeddings/core.py 93.40% <100.00%> (+9.41%) ⬆️

@AntObi AntObi merged commit ba87938 into main Aug 7, 2023
12 checks passed
@AntObi AntObi deleted the doc_updates branch August 7, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant