Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Signature and Callback (Issues WP-API/OAuth1#59, WP-API/OAuth1#64, WP-API/OAuth1#91) #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Signature and Callback (Issues WP-API/OAuth1#59, WP-API/OAuth1#64, WP-API/OAuth1#91) #92

wants to merge 3 commits into from

Commits on Nov 6, 2015

  1. Ensure OAuth1 signature is created as per the spec

    @AlexC @coderkevin
    AlexC authored and coderkevin committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    0cb6065 View commit details
    Browse the repository at this point in the history

  2. Remove normalize_parameters function. 

    This function was actually decoding parameters that shouldn't have been
decoded, then re-encoding them.

See: #91

The idea behind removing this function is that parameters should be
encoded as needed, not through a brute-force function like this, which
can cause unintended side-effects for parameters which contain portions
that are already encoded.
    @coderkevin
    coderkevin committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    c41eb30 View commit details
    Browse the repository at this point in the history

  3. Fix issue #59, OAuth callback isn't called

    @sblaz @coderkevin
    sblaz authored and coderkevin committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    dd283fa View commit details
    Browse the repository at this point in the history