This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Abstract revisions to dedicated controller; only include revisioned fields #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WP-API/amigos #reviewmerge |
|
|
||
| $post = get_post( $request['id'] ); | ||
| if ( ! $post || 'revision' !== $post->post_type ) { | ||
| return new WP_Error( 'json_post_invalid_id', __( 'Invalid revision ID.' ), array( 'status' => 404 ) ); |
There was a problem hiding this comment.
Elsewhere we have not thrown invalid errors in the permissions checks. We'd typically not return any error in the case of the post not existing, or being the wrong post type - and handle that check in the get_item callback it's self.
|
Just a concern around the error checking done in the permissions callbacks, as I'm not sure if that is the best place for those checks. Apart from that - I'm happy. |
joehoyle
added a commit
that referenced
this pull request
Apr 17, 2015
Abstract revisions to dedicated controller; only include revisioned fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #869, #855
See #894, #314