Only allow custom meta of types string, number and boolean #2850

joehoyle · 2016-10-17T18:21:55Z

Currently we handle registering meta even if your register the type as
anything other than boolean number and string, however we don't
currently have great ways to handle non-scaler meta. For now, let's
whitelist these types and throw a doing_it_wrong if meta is registered
with an invalid type.

Currently we handle registering meta even if your register the type as anything other than `boolean` `number` and `string`, however we don't currently have great ways to handle non-scaler meta. For now, let's whitelist these types and throw a `doing_it_wrong` if meta is registered with an invalid type.

kadamwhite · 2016-10-17T18:40:42Z

How do we handle namespacing of objects in meta? e.g., if I'm an seo plugin and I have a "score" meta value, but there's also a keyword-bingo plugin that also has a "score," and I only have a numeric meta field to put them in -- not an object -- how do I ensure there won't be a conflict?

kadamwhite · 2016-10-17T18:41:57Z

lib/fields/class-wp-rest-meta-fields.php

@@ -294,6 +300,10 @@ protected function get_registered_fields() {
 						'type' => $args['type'],
 					);
 				}
+			} else {
+				if ( ! in_array( $rest_args['schema']['type'], array( 'number', 'string', 'boolean' ), true ) ) {


kadamwhite reviewed Oct 17, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only allow custom meta of types string, number and boolean #2850

Only allow custom meta of types string, number and boolean #2850

joehoyle commented Oct 17, 2016

kadamwhite commented Oct 17, 2016

kadamwhite Oct 17, 2016

Only allow custom meta of types string, number and boolean #2850

Are you sure you want to change the base?

Only allow custom meta of types string, number and boolean #2850

Conversation

joehoyle commented Oct 17, 2016

kadamwhite commented Oct 17, 2016

kadamwhite Oct 17, 2016

Choose a reason for hiding this comment