Fix manual token creation with plain permalinks

[jkmassel]

Uses the built-in get_rest_url API inside of get_rest-uri – this results in permalink-style-aware URI generation.

Fixes #4

To Test:
Before – set a site to use default plain permalinks. Attempt to create a manual token. It should fail with a network error.
After – set a site to use default plain permalinks. Attempt to create a manual token. It should succeed.

[jkmassel]

The test is failing here, because the updated get_rest_uri function produces absolute URLs, rather than relative ones:

1) Test_WP_REST_Key_Pair::test_get_rest_uri
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/wp-json/wp/v2/key-pair'
+'http://example.org/wp-json/wp/v2/key-pair'

IMHO using absolute URIs is the way to go (otherwise how would subdomain multi-site installs work?), so I'd like to update the test. However, I'd love an explicit 👍 from a reviewer on that approach.

[valendesigns]

Hi @jkmassel sorry but I don't understand this PR. I currently have default permalinks set on the site I've been developing on, as a matter of fact, I have the entire time I've developed the plugin. I'm not sure I get what the intent is here because what you're saying is broken is working fine for me. I could only assume that there is something I'm either missing in the setup or you have a conflict from another active plugin. Could you explain the steps to reproduce the issue? I have /%postname%/ set as my permalink structure and I'm able to create a token at this endpoint /wp-json/wp/v2/token using postman and an API key/secret without any issue, what am I missing?

edit:
I think what you're after is that the plain permalink is not working when you add a new key-pair in the admin. I'll look at it now.

[valendesigns]

/wp/v2/key-pair is not a public API, it is meant for the user profile only.

[jkmassel]

I think what you're after is that the plain permalink is not working when you add a new key-pair in the admin. I'll look at it now.

Yep that's right – sorry about the confusion. Updated the initial PR description to hopefully prevent future confusion.

[jkmassel]

Closing in favour of #12