Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README.md #9

Merged
merged 3 commits into from
May 10, 2019
Merged

Create README.md #9

merged 3 commits into from
May 10, 2019

Conversation

jkmassel
Copy link
Collaborator

Adds a README file.

I've added some general documentation , as well as a how-to-use section for retrieving and using a token.

I'm not sure that the key pair functionality would be considered a public API – AFAICT it's designed for use in wp-admin, and you need to be logged in to use it. Let me know if that's incorrect – happy to add more for that functionality, but I might need some info on the use case for your average developer.

If there's anything else we'd like to document at this point, happy to add it in this PR or another!

@jkmassel jkmassel added the enhancement New feature or request label Apr 25, 2019
@jkmassel jkmassel self-assigned this Apr 25, 2019
@valendesigns
Copy link
Collaborator

I've review this later today, and your other PR's. Sorry for the long wait.

@valendesigns
Copy link
Collaborator

This is a great start. I'll update and fill in a few things and merge it later today. Thank you @jkmassel

@jkmassel
Copy link
Collaborator Author

jkmassel commented May 9, 2019

Thanks @valendesigns – if you'd prefer, we could merge this as-is and I could do a PR targeting master to add docs for that, if it's helpful?

@valendesigns valendesigns merged commit 191ac93 into develop May 10, 2019
@valendesigns valendesigns deleted the add-readme branch May 10, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants