Cleanup WPRequest and add tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will be using this, but not here, and not yet
(Also improves the superagent mock)
delete is a reserved word, but that won't cause any significant problems of which I am aware within the Node environment and it reserves the intent of the method to keep the verb the same as HTTP's
|
Ready for review: Critique welcomed, particularly on the tests! |
| if ( err || result.error ) { | ||
| reject( err || result.error ); | ||
| } else { | ||
| resolve( result ); | ||
| resolve( transform( result ) ); |
There was a problem hiding this comment.
@bmac, @carldanley and I were talking about these lines—we've both seen code like this in which the actual reject and resolve are return'd, rather than just called. Is there any issue of which you are aware why we'd want to return these statements, likc
if ( err || result.error ) {
return reject( err || result.error );
} else {
return resolve( transform( result ) );
}instead of just calling the functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
.get()with no callback throws an error, and test coverage in WPRequest (the core of this shebang) is pretty poor. This PR rounds out the tests for the HTTP methods (excepting PATCH), and fixes some internal logical errors within WPRequest that were leading to errors or unexpected results.