Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Commit

Permalink
Fix major AfC/R bug that caused all of the review interfaces to stack up
Browse files Browse the repository at this point in the history
This would occur if the user changed their mind -- e.g., clicked
"Accept" and then "Decline." Both the accept and decline options would
be visible on screen (since the old options were never removed -- once
again the jquery conversion…)
  • Loading branch information
theopolisme committed Sep 28, 2013
1 parent 889c697 commit 91c51be
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/redirects.js
Expand Up @@ -173,8 +173,8 @@ function afcHelper_redirect_init() {
function afcHelper_redirect_onActionChange(id) {
var extra = $("#afcHelper_redirect_extra_" + id);
var selectValue = $("#afcHelper_redirect_action_" + id).val();
if (selectValue === 'none') extra.html('');
else if (selectValue === 'accept') {
extra.html(''); // Blank it first
if (selectValue === 'accept') {
if (afcHelper_Submissions[id].type === 'redirect') {
extra.html(extra.html() + '<label for="afcHelper_redirect_from_' + id + '">From: </label><input type="text" ' + 'name="afcHelper_redirect_from_' + id + '" id="afcHelper_redirect_from_' + id + '" value="' + afcHelper_escapeHtmlChars(afcHelper_Submissions[id].title) + '" />');
extra.html(extra.html() + '&nbsp;<br /><label for="afcHelper_redirect_to_' + id + '">To: </label><input type="text" ' + 'name="afcHelper_redirect_to_' + id + '" id="afcHelper_redirect_to_' + id + '" value="' + afcHelper_escapeHtmlChars(afcHelper_Submissions[id].to) + '" />');
Expand Down

0 comments on commit 91c51be

Please sign in to comment.