Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

TypeError: afcHelper_pageStatuses.push is not a function #210

Open
Technical-13 opened this issue Dec 29, 2013 · 6 comments
Open

TypeError: afcHelper_pageStatuses.push is not a function #210

Technical-13 opened this issue Dec 29, 2013 · 6 comments

Comments

@Technical-13
Copy link
Contributor

Freezing the script up trying to mark what the script thinks is G13 eligible draft with the AfC draft template. The pages are userspace drafts with no AfC template, so the script thinking they are G13 eligible is also wrong to begin with...

https://github.com/WPAFC/afch/blob/develop/src/submissions.js#L1358

@theopolisme
Copy link
Contributor

Link to test? I think it was because it was set to false and then the script recalculated it...

@Technical-13
Copy link
Contributor Author

@hasteur
Copy link
Member

hasteur commented Jan 5, 2014

Sorry, 6f7039a is wrong.

"Rejected or unsubmitted Articles for creation pages that have not been edited in over six months. This criterion applies to all drafts in WikiProject Articles for creation project and talk namespaces, as well as all userspace drafts that are using the project's {{AFC submission}} template." per https://en.wikipedia.org/wiki/Wikipedia:G13#G13.

If it's user space and there's at least one AFC submission template (either draft or declined), the page is eligible. The new Draft namspace would also have G13 eligible submissions in the near future.

@theopolisme
Copy link
Contributor

Well, you know better than I do! Revert, please :)

@hasteur
Copy link
Member

hasteur commented Jan 5, 2014

Ok, a pair of changesets:
1d10c2b: Adds User/Talk and Draft/Talk namespaces to the list that will be monitored.
9ec828e: Gives a short circuit path if there's no AFC template on the page

@hasteur
Copy link
Member

hasteur commented Jan 5, 2014

and 8417450: which fixes a bug I introduced

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants