Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky nav overflow method puts items both in the "More" overflow menu and the "More" global-nav menu #1336

Closed
benlk opened this issue Oct 10, 2016 · 2 comments
Assignees
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 10, 2016

screen shot 2016-10-10 at 10 35 11 am

if you’re at a desktop size it puts the extra categories from the main nav into a “more” dropdown but duplicates them in the other “more” dropdown within that dropdown (where the global nav items go)

@benlk benlk added type: bug priority: high Either blocks work on a priority-normal task or a solution here informs other work. labels Oct 10, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Oct 10, 2016
@benlk benlk self-assigned this Oct 10, 2016
@benlk
Copy link
Collaborator Author

benlk commented Oct 11, 2016

https://github.com/INN/Largo/blob/develop/js/navigation.js#L272 is the problem line, I think. That selector can be ambiguous.

@benlk
Copy link
Collaborator Author

benlk commented Oct 11, 2016

No, it's https://github.com/INN/Largo/blob/develop/js/navigation.js#L274:

overflow.find('ul#menu-more-1').prepend(li);

If the name of the Global Navigation menu slugifies to "more", then the slug of the menu name causes a conflict somehow. Changing the name of the identifier for the overflow menu when we create it in navigation.js fixes the problem, and because it's contained all within one file, can be deployed without worrying about cache conflicts between Javascript and PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug
Projects
None yet
Development

No branches or pull requests

1 participant