Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace file_get_contents with WordPress filesystem functions. #1526

Closed
benlk opened this issue Sep 9, 2018 · 4 comments
Closed

Replace file_get_contents with WordPress filesystem functions. #1526

benlk opened this issue Sep 9, 2018 · 4 comments
Labels
Estimate: < 2 Hours hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin. status: needs tests type: tech debt For necessary updates because code is old
Milestone
0.7 - Foundation ...

Comments

@benlk
Copy link
Collaborator

benlk commented Sep 9, 2018

As part of #844:

inc/avatars/admin.php:59: @file_get_contents($_FILES[LARGO_AVATAR_INPUT_NAME]['tmp_name'])

Relevant reading: https://developer.wordpress.org/reference/functions/wp_filesystem/
@benlk benlk added this to the 0.6 - Performance & SEO milestone Sep 9, 2018
@benlk benlk modified the milestones: 0.6.1 - Bugfixes, 0.6.2 Dec 7, 2018
@benlk benlk added Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. status: needs tests type: tech debt For necessary updates because code is old labels Aug 22, 2019
@benlk
Copy link
Collaborator Author

benlk commented Aug 22, 2019

replace file_get_contents with WordPress filesystem calls

@omnisite
Copy link

omnisite commented Oct 8, 2019

@benlk I can pick this one up, if you want?

@benlk
Copy link
Collaborator Author

benlk commented Oct 9, 2019

Please do!

@omnisite
Copy link

omnisite commented Oct 9, 2019

@benlk Ok, will do!

@omnisite omnisite mentioned this issue Oct 12, 2019
Closed
@joshdarby joshdarby linked a pull request Mar 27, 2021 that will close this issue
1526-replace-file-get-contents | replace file_get_contents with WP_Fi… #1815
Closed
@joshdarby joshdarby removed a link to a pull request Mar 27, 2021
1526-replace-file-get-contents | replace file_get_contents with WP_Fi… #1815
Closed
@joshdarby joshdarby mentioned this issue Mar 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimate: < 2 Hours hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin. status: needs tests type: tech debt For necessary updates because code is old
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

No branches or pull requests
3 participants
@benlk @omnisite @joshdarby