Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Largo Disclaimer Widget doesn't display title or title link #1738

Closed
benlk opened this issue Jul 9, 2019 · 1 comment
Closed

Largo Disclaimer Widget doesn't display title or title link #1738

benlk opened this issue Jul 9, 2019 · 1 comment
Labels
status: wontfix type: bug type: question

Comments

@benlk
Copy link
Collaborator

benlk commented Jul 9, 2019

Following up on #1736 for #1717, the decision was made to check all Largo widgets to see if they output the widget title safely.

The disclaimer widget doesn't. https://github.com/INN/largo/blob/aa45901f61d1b8840512e603780b29853f3bbf80/inc/widgets/largo-disclaimer-widget.php#L20-L32

Should it?
@benlk
Copy link
Collaborator Author

benlk commented Jul 9, 2019

I'm marking this as wontfix for Largo; this should be addressed in the Disclaimer widget in https://github.com/INN/disclaimers because that's the post-0.6 plan for Largo.

This issue already exists there: INN/disclaimers#6

@benlk benlk closed this as completed Jul 9, 2019
@benlk benlk mentioned this issue Jul 9, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wontfix type: bug type: question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benlk