Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-column classic template should display featured image by default, and filter out duplicate images #934

Closed
benlk opened this issue Oct 21, 2015 · 1 comment
Assignees
Labels
priority: normal Must be completed before release of this version of plugin. type: question

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 21, 2015

From HELPDESK-428:

discuss whether we might just want to show featured images here by default and filter out dupes as we have with some sites.

Right now, partials/content-single-classic.php does not display the featured image, and we might want it to do so.

Duplicate filtering can be done with largo_remove_hero by removing the check for the single template


This would be a good time to grab #590 as well.

@benlk benlk added this to the 0.5.5 - Story Elements milestone Oct 21, 2015
@aschweigert
Copy link

I feel like the behavior should be the same for the single column and two column layouts. It's almost certainly confusing for users to have it behave differently. And since we have the "add featured media" button there no matter what, it would seem to me that the expectation would be to show the featured image by default (on both layouts)

@aschweigert aschweigert added the priority: normal Must be completed before release of this version of plugin. label Oct 21, 2015
@benlk benlk changed the title Should the 2-column classic template display featured image by default, and filter out duplicate images? 2-column classic template should display featured image by default, and filter out duplicate images Jan 4, 2016
@benlk benlk closed this as completed Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. type: question
Projects
None yet
Development

No branches or pull requests

2 participants