Updated slider #1307
Updated slider #1307
Conversation
There was a problem hiding this comment.
I'm not sure that all of this is related to this PR, but this is the first time I'm reviewing this functionality so I'll drop it all here and we can break out if necessary.
I've highlighted the main content div in gray and the slideshow navigation in blue to make it easier to see.
<div class="hero is-gallery span12">has a left margin from the span12 class that needs to be overridden. This will center the slideshow & navigation around the post content div<ul class="slick-dots" style="display: flex;">haspadding: 0 17.0213%;applied to it, which is pushing it to the right.
Aside from those, this looks 1,000x better than what was there before, and especially the navigation on the top
|
Also, if this hasn't been tested with the two column story layout, we should double check that as well. |
There was a problem hiding this comment.
2-column layout has the same problem with the slideshow top grip/navigation, but not the issue with the slideshow itself being bumped over (because there's no 12-col span).
One interesting note here is that the right navigation overflows into the widget area, so I'm thinking we should remove the 40px padding here. It'll mean that the navigation covers the edge of the photo, but I think that's preferable to covering the sidebar.
@Julia67 what's your opinion on this? We could also make the background transparent instead of the current white (or blue in the screenshot), and also move these in, so they're both in the right spot but not cutting off any of the image?
opening a PR for this to review for 0.5.5