Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make things happen on homepage when featured media is not an image #832

Merged
merged 15 commits into from
Aug 13, 2015

Conversation

rnagle
Copy link

@rnagle rnagle commented Aug 11, 2015

For #391.

What this pull request includes:

  • When featured media is set to embed code, allow the user to upload their own thumbnail image
  • When featured media is set to video, allow user to import thumbnail via oemebd or override oembed thumbnail with their own thumbnail image

To do:

  • When featured media is a gallery, ensure that the first image in the gallery is used as the "cover photo"/featured image for use on the homepage, in blog rivers, etc.

@rnagle rnagle added priority: normal Must be completed before release of this version of plugin. status: in progress status: needs docs status: needs review labels Aug 11, 2015
@rnagle rnagle added this to the 0.5.2 - Bugfixes Only (Please) milestone Aug 11, 2015
@rnagle
Copy link
Author

rnagle commented Aug 12, 2015

This is now ready for review/testing and consideration for merge.

@aschweigert aschweigert assigned rnagle and unassigned aschweigert Aug 13, 2015
@aschweigert
Copy link

throwing back to @rnagle to double check my last couple of changes but otherwise I think this is ready to go

…o check if sidebar is registered and active -- meaning it actually has widgets assigned. also, stubbed out tests for inc/widgets.php
rnagle added a commit that referenced this pull request Aug 13, 2015
Make things happen on homepage when featured media is not an image
@rnagle rnagle merged commit 71f81d0 into develop Aug 13, 2015
@rnagle rnagle deleted the 391-featured-media branch September 10, 2015 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: needs docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants