Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save settings with the right format #868

Closed
giucu91 opened this issue Oct 20, 2023 · 2 comments
Closed

Save settings with the right format #868

giucu91 opened this issue Oct 20, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@giucu91
Copy link
Contributor

giucu91 commented Oct 20, 2023

{ "type": "custom-grid", "grid_type": "", "grid_row_height": "", "grid_justify_last_row": "", "grid_image_size": "medium", "grid_image_dimensions": "", "img_size": "", "img_crop": "0", "grid_image_crop": "0", "gutter": "10", "tablet_gutter": "10", "mobile_gutter": "10", "width": "", "height": "", "randomFactor": "", "shuffle": "0", "lightbox": "fancybox", "show_navigation": "1", "hide_title": "1", "titleColor": "", "titleFontSize": 0, "mobileTitleFontSize": "12", "hide_description": "0", "captionColor": "#ffffff", "captionFontSize": 14, "mobileCaptionFontSize": "10", "enableSocial": "0", "enableTwitter": "0", "enableFacebook": "0", "enableWhatsapp": "0", "enableLinkedin": "0", "enablePinterest": "0", "enableEmail": "0", "emailSubject": "Check out this awesome image !!", "emailMessage": "Here is the link to the image : %%image_link%% and this is the link to the gallery : %%gallery_link%%", "socialIconColor": "#ffffff", "socialIconSize": 16, "socialIconPadding": 10, "loadedScale": 100, "inView": "0", "effect": "pufrobo", "cursor": "zoom-in", "borderSize": 0, "borderRadius": 0, "borderColor": "#ffffff", "shadowSize": 0, "shadowColor": "#ffffff", "lazy_load": "1", "enable_responsive": "0", "tablet_columns": "2", "mobile_columns": "1", "style": "", "last_visited_tab": "modula-general", "helpergrid": 0, "images": [], "galleryId": 9, "galleryTitle": "", "fontSize": 16, "imageTitleVisibility": "visible", "galleryType": "masonry" }

He have number that are strings, we have number that are boolean.

  1. We need to ensure that we save the right format.
  2. We need to check the type of settings for the REST responses.
@giucu91 giucu91 added the bug label Oct 20, 2023
@TeoAlex TeoAlex self-assigned this Oct 23, 2023
TeoAlex added a commit that referenced this issue Oct 23, 2023
TeoAlex added a commit to TeoAlex/modula-lite that referenced this issue Oct 23, 2023
TeoAlex added a commit to TeoAlex/modula-lite that referenced this issue Oct 23, 2023
@razvanaldea89 razvanaldea89 added this to the 2.7.10 milestone Jan 17, 2024
@razvanaldea89
Copy link
Contributor

@TeoAlex please check all fields and their data type to correspond between saving them, retrieving them and defining them.

@razvanaldea89
Copy link
Contributor

Seems like on a talk between @giucu91 and @TeoAlex the settings should remain the same, at least for now. Going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants