Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria attributes and accessibility doesn't seem to be implemented correctly #884

Closed
cristianraiber opened this issue Dec 7, 2023 · 8 comments
Assignees
Milestone

Comments

@cristianraiber
Copy link
Contributor

More info here: https://wordpress.org/support/topic/aria-attributes-do-not-match-their-roles-5/

@giucu91 giucu91 added this to the 2.8.0 milestone Feb 1, 2024
@TeoAlex TeoAlex self-assigned this Feb 5, 2024
@TeoAlex TeoAlex added the working label Feb 5, 2024
@TeoAlex
Copy link
Contributor

TeoAlex commented Feb 5, 2024

Could not reproduce the issue
image

@itineris-milos
Copy link

Hi guys, when we can expect the new update for the accessibility issue? We can still replicate
Thanks

@cristianraiber
Copy link
Contributor Author

@itineris-milos - can you please tell me how you replicate the issue? we couldn't replicate it at our ends

@itineris-milos
Copy link

@cristianraiber See attached screen, you can replicate with the Lightbox option selected.

image

URL: https://demo.wp-modula.com/modula-gallery/watermark/

Thanks

TeoAlex added a commit that referenced this issue Apr 11, 2024
@cristianraiber
Copy link
Contributor Author

@itineris-milos - fix has been added by @TeoAlex here: 1c7f729

It will be available in our next product update.

@itineris-milos
Copy link

Thanks @cristianraiber for the quick action, appreciate really

@cristianraiber
Copy link
Contributor Author

@itineris-milos

If you want to apply this fix now you can add the following code at the end of your functions.php file in the active theme's directory.

add_filter( 'modula_shortcode_item_data', 'modula_aria_label_fix', 16, 3 );
function modula_aria_label_fix( $item_data, $item, $settings ){
	if( 'fancybox' == $settings['lightbox'] ){
		$item_data['link_attributes']['role'] = 'button';
	}
	return $item_data;
}

@itineris-milos
Copy link

Awesome, I'll give it a go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants