-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Normalization into Solo 8 Base Environment #47
Conversation
Pull Request Test Coverage Report for Build 630006467
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor 2 comments. Feel free to ignore them and I can merge it in without them
gym_solo/core/obs.py
Outdated
a = np.array(values) | ||
low = obs.observation_space.low | ||
hi = obs.observation_space.high | ||
values = (2 * (a - low)) / (hi - low) - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a minor comment but add an extra parenthesis for clarity?
values = ((2 * (a - low)) / (hi - low)) - 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
gym_solo/envs/solo8v2vanilla.py
Outdated
a = np.array(action) | ||
low = self._action_space.low | ||
hi = self._action_space.high | ||
action = low + ((a + 1) * (hi - low)) / 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about parenthesis to make it easier to read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
All comments should be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The observation factory and the base RL class have been modified so that the respective spaces are valued in
[-1, 1]