Merge pull request #295 from WPMedia/AIO-342

Prevent GH actions from failing AIO-342
WPMedia · Nov 30, 2020 · c80534c · c80534c
2 parents 0b16003 + 892087f
commit c80534c
Show file tree

Hide file tree

Showing 24 changed files with 850 additions and 108 deletions.
diff --git a/.changeset/silent-ravens-train.md b/.changeset/silent-ravens-train.md
@@ -0,0 +1,21 @@
+---
+'@wpmedia/feeds-source-collections-block': minor
+'@wpmedia/feeds-source-content-api-block': minor
+'@wpmedia/feeds-source-video-api-block': minor
+'@wpmedia/mrss-feature-block': minor
+'@wpmedia/rss-fbia-feature-block': minor
+'@wpmedia/rss-feature-block': minor
+'@wpmedia/rss-flipboard-feature-block': minor
+'@wpmedia/rss-google-news-feature-block': minor
+'@wpmedia/rss-msn-feature-block': minor
+'@wpmedia/sitemap-feature-block': minor
+'@wpmedia/sitemap-index-feature-block': minor
+'@wpmedia/sitemap-news-feature-block': minor
+'@wpmedia/sitemap-video-feature-block': minor
+'@wpmedia/feeds-content-elements': minor
+'@wpmedia/feeds-find-video-stream': minor
+'@wpmedia/feeds-resizer': minor
+'@wpmedia/feeds-xml-output': minor
+---
+
+change map() to forEach()
diff --git a/blocks/feeds-source-content-api-block/package-lock.json b/blocks/feeds-source-content-api-block/package-lock.json
diff --git a/blocks/feeds-source-video-api-block/package-lock.json b/blocks/feeds-source-video-api-block/package-lock.json
diff --git a/blocks/mrss-feature-block/package-lock.json b/blocks/mrss-feature-block/package-lock.json
diff --git a/blocks/rss-fbia-feature-block/features/rss/xml.js b/blocks/rss-fbia-feature-block/features/rss/xml.js
@@ -330,91 +330,93 @@ export function FbiaRss({ globalContent, customFields, arcSite }) {
       const maxRows =
         numRows === 'all'
           ? 9999
-          : parseInt(numRows)(s.content_elements || []).map((element) => {
-              if (body.length <= maxRows) {
-                switch (element.type) {
-                  case 'blockquote':
-                    item = this.blockquote(element)
-                    break
-                  case 'correction':
-                    item = this.correction(element)
-                    break
-                  case 'code':
-                  case 'custom_embed':
-                  case 'divider':
-                  case 'element_group':
-                  case 'story':
-                    item = ''
-                    break
-                  case 'endorsement':
-                    item = this.endorsement(element)
-                    break
-                  case 'gallery':
-                    item = this.gallery(
-                      element,
-                      resizerKey,
-                      resizerURL,
-                      resizeWidth,
-                      resizeHeight,
-                    )
-                    break
-                  case 'header':
-                    item = this.header(element)
-                    break
-                  case 'image':
-                    item = this.image(
-                      element,
-                      resizerKey,
-                      resizerURL,
-                      resizeWidth,
-                      resizeHeight,
-                    )
-                    break
-                  case 'interstitial_link':
-                    item = this.interstitial(element, domain)
-                    break
-                  case 'link_list':
-                    item = this.linkList(element, domain)
-                    break
-                  case 'list':
-                    item = this.list(element)
-                    break
-                  case 'list_element':
-                    item = this.listElement(element)
-                    break
-                  case 'numeric_rating':
-                    item = this.numericRating(element)
-                    break
-                  case 'oembed_response':
-                    item = this.oembed(element)
-                    break
-                  case 'quote':
-                    item = this.quote(element)
-                    break
-                  case 'raw_html':
-                    item = this.text(element)
-                    break
-                  case 'table':
-                    item = this.table(element)
-                    break
-                  case 'text':
-                    item = this.text(element)
-                    break
-                  case 'video':
-                    item = this.video(element)
-                    break
-                  default:
-                    item = this.text(element)
-                    break
-                }
+          : parseInt(numRows)(s.content_elements || []).array.forEach(
+              (element) => {
+                if (body.length <= maxRows) {
+                  switch (element.type) {
+                    case 'blockquote':
+                      item = this.blockquote(element)
+                      break
+                    case 'correction':
+                      item = this.correction(element)
+                      break
+                    case 'code':
+                    case 'custom_embed':
+                    case 'divider':
+                    case 'element_group':
+                    case 'story':
+                      item = ''
+                      break
+                    case 'endorsement':
+                      item = this.endorsement(element)
+                      break
+                    case 'gallery':
+                      item = this.gallery(
+                        element,
+                        resizerKey,
+                        resizerURL,
+                        resizeWidth,
+                        resizeHeight,
+                      )
+                      break
+                    case 'header':
+                      item = this.header(element)
+                      break
+                    case 'image':
+                      item = this.image(
+                        element,
+                        resizerKey,
+                        resizerURL,
+                        resizeWidth,
+                        resizeHeight,
+                      )
+                      break
+                    case 'interstitial_link':
+                      item = this.interstitial(element, domain)
+                      break
+                    case 'link_list':
+                      item = this.linkList(element, domain)
+                      break
+                    case 'list':
+                      item = this.list(element)
+                      break
+                    case 'list_element':
+                      item = this.listElement(element)
+                      break
+                    case 'numeric_rating':
+                      item = this.numericRating(element)
+                      break
+                    case 'oembed_response':
+                      item = this.oembed(element)
+                      break
+                    case 'quote':
+                      item = this.quote(element)
+                      break
+                    case 'raw_html':
+                      item = this.text(element)
+                      break
+                    case 'table':
+                      item = this.table(element)
+                      break
+                    case 'text':
+                      item = this.text(element)
+                      break
+                    case 'video':
+                      item = this.video(element)
+                      break
+                    default:
+                      item = this.text(element)
+                      break
+                  }
 
-                // empty array breaks xmlbuilder2, but empty '' is OK
-                if (Array.isArray(item) && item.length === 0) {
-                  item = ''
+                  // empty array breaks xmlbuilder2, but empty '' is OK
+                  if (Array.isArray(item) && item.length === 0) {
+                    item = ''
+                  }
+                  item && body.push(item)
                 }
-                item && body.push(item)
-              }
-            })
+              },
+            )
       return body.length ? body : ['']
     }
     this.image = (element, resizerKey, resizerURL) => {