Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX - TMEDIA-495 Horizontal Links Defect #1093

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

matthewroach
Copy link
Contributor

Description

Update the CSS to fix the specificity with the updates to parent components now being Styled Components

https://styled-components.com/docs/advanced#issues-with-specificity

Jira Ticket

Test Steps

  • Add test steps a reviewer must complete to test this PR
  1. Checkout this branch git checkout TMEDIA-495-horizontal-links
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/header-nav-chain-block
  3. Navigate to the homepage - http://localhost/homepage/?_website=the-gazette
  4. Validate the horizontal links in the header nav chain
    • are visible on desktop viewport
    • are not shown on non desktop viewports

Effect Of Changes

Before

TMEDIA-495-before

After

TMEDIA-495-after

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@matthewroach matthewroach requested a review from a team as a code owner September 20, 2021 19:58
Copy link
Contributor

@JackHowa JackHowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected in my testing; nice work

after:

Screen Shot 2021-09-20 at 15 11 33
Screen Shot 2021-09-20 at 15 10 20

before:
Screen Shot 2021-09-20 at 15 12 58

@matthewroach matthewroach merged commit aa79639 into beta Sep 20, 2021
@matthewroach matthewroach deleted the TMEDIA-495-horizontal-links branch September 20, 2021 20:24
matthewroach added a commit that referenced this pull request Sep 20, 2021
HOTFIX - TMEDIA-495 Horizontal Links Defect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants