Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update #106

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Readme update #106

merged 2 commits into from
Nov 14, 2023

Conversation

nschubach
Copy link
Contributor

Description

Information about what you changed for this PR

Jira Ticket

Acceptance Criteria

copy from ticket

Test Steps

  • Add test steps a reviewer must complete to test this PR

Effect Of Changes

Before

Example: When I clicked the search button, the button turned red.

[include screenshot or gif or link to video, storybook would be awesome]

After

Example: When I clicked the search button, the button turned green.

[include screenshot or gif or link to video, storybook would be awesome]

Dependencies or Side Effects

Examples of dependencies or side effects are:

  • Additional settings that will be required in the blocks.json
  • Changes to the custom fields which will require users to reconfigure features
  • Update to css framework or SDK
  • Dependency on another PR that needs to be merged first

Review Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps above are working
  • Confirmed there are no linter errors
  • Confirmed this PR has reasonable code coverage
    • Confirmed this PR has unit test files
    • Ran npm test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

@nschubach nschubach merged commit 73e6c5c into arc-themes-release-version-1.30 Nov 14, 2023
2 checks passed
@nschubach nschubach deleted the readme-update branch November 14, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant