Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store PNG/SVG exports with inline DST file #83

Closed
hschwentner opened this issue Jul 7, 2020 · 2 comments
Closed

Store PNG/SVG exports with inline DST file #83

hschwentner opened this issue Jul 7, 2020 · 2 comments
Labels
feature concrete new feature or request
Projects

Comments

@hschwentner
Copy link
Member

Is your feature request related to a problem? Please describe.
When I use a SVG or PNG file that is an export of a domain story, I usually want to edit it later. In most cases I forgot where I stored the corresponding DST file or there never was one.

Describe the solution you'd like
I want to store the JSON from the DST file in the SVG/PNG file as well. This way, the picture files would become editable and everything would be in one place.

Additional context
Draw.io uses a similar approach. In SVG the data is stored in a "content" attribute of the "svg" tag. The See JGraph/mxgraph.

AlexanderZellober added a commit that referenced this issue Jul 7, 2020
@AlexanderZellober AlexanderZellober added this to To do in v1.2.0 via automation Jul 7, 2020
@AlexanderZellober AlexanderZellober moved this from To do to In progress in v1.2.0 Jul 7, 2020
@AlexanderZellober
Copy link
Member

For SVG there is an implementation on FeatureTest

Exporting it to a PNG seems a bit tricky

@AlexanderZellober AlexanderZellober self-assigned this Jul 7, 2020
@AlexanderZellober AlexanderZellober added the feature concrete new feature or request label Jul 7, 2020
@AlexanderZellober AlexanderZellober moved this from In progress to Done in v1.2.0 Aug 26, 2020
@AlexanderZellober AlexanderZellober removed their assignment Sep 11, 2020
AlexanderZellober added a commit that referenced this issue Oct 28, 2020
Adds Alert when an SVG is uploaded without a domain story attached
hofstef added a commit that referenced this issue Oct 28, 2020
@hofstef
Copy link
Member

hofstef commented Oct 28, 2020

  • starting with v1.2.0, exported SVG will containd embedded JSON (the .dst file). Hence, the file extension was changed from .svg to .dst.svg
    • in v1.2.0, .dst and .svg (with embedded JSON) can be importet. To give users more freedom to rename their files, we opted to set the file filter in the import dialog to .dst and .svg (rather than the more restrivtive .dst.svg)
    • in future versions, we might switch to .dst.svg as default export format (but keep .dst import for compatibility reasons)
  • exported PNG do not yet contain embedded .dst JSON

@hofstef hofstef closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature concrete new feature or request
Projects
No open projects
v1.2.0
  
Done
Development

No branches or pull requests

3 participants