Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Minimum PHP version option not working #102

Closed
surimohnot opened this issue Feb 26, 2019 · 7 comments
Closed

Minimum PHP version option not working #102

surimohnot opened this issue Feb 26, 2019 · 7 comments
Assignees
Labels
Type: Bug There is a bug in the plugin.

Comments

@surimohnot
Copy link

To re-produce this error, check latest version of my theme at https://themes.trac.wordpress.org/ticket/63695. Set minimum php version to 5.4 and run the plugin sniffer. It will still show all errors related to keywords or syntax available in PHP 5.4.

@dingo-d
Copy link
Member

dingo-d commented Feb 26, 2019

I will try to test this using the plugin, but I didn't get any errors when manually running the PHPCompatibility sniff. Thanks for reporting this :)

@dingo-d dingo-d self-assigned this Feb 26, 2019
@dingo-d dingo-d added the Type: Bug There is a bug in the plugin. label Feb 26, 2019
@joyously
Copy link

Doesn't minimum PHP version mean that that is the version that is checked for? The description sounds correct. What are you saying the problem is?

@surimohnot
Copy link
Author

Description is correct. The problem is, if I have selected Minimum PHP version as 5.4 and run the sniffer, It should not show an error saying "Short array syntax (open) is available since 5.4".

@ernilambar
Copy link
Member

I can confirm this bug. Plugin is not respecting the PHP version dropdown.

@dingo-d
Copy link
Member

dingo-d commented Feb 27, 2019

I'll test this with some more themes and see what's causing this. Must be some config issue

timelsass referenced this issue in timelsass/theme-sniffer Mar 1, 2019
@dingo-d
Copy link
Member

dingo-d commented Mar 1, 2019

I've updated the zip file, can you check for the issue now?

https://github.com/WPTRT/theme-sniffer/releases/download/1.0.0-RC1/theme-sniffer.zip

@dingo-d
Copy link
Member

dingo-d commented Mar 4, 2019

This has been fixed and is in the current zip so I'll close the issue.

@dingo-d dingo-d closed this as completed Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug There is a bug in the plugin.
Projects
None yet
Development

No branches or pull requests

4 participants