feat: handle disabled options in select v.4 #1317

RobelTekle · 2022-05-24T15:25:14Z

add disabled in Option
mimic isMultiple style and behavior (when user try to select an already selected option)

packages/Select/index.test.tsx

packages/Select/index.tsx

packages/Select/styles.ts

feat: handle disabled options in select

bed35f5

RobelTekle requested a review from a team May 24, 2022 15:27

RobelTekle changed the title ~~feat: handle disabled options in select~~ feat: handle disabled options in select V4 May 24, 2022

RobelTekle changed the title ~~feat: handle disabled options in select V4~~ feat: handle disabled options in select v.4 May 24, 2022

cnairiwttj reviewed May 24, 2022

View reviewed changes

packages/Select/index.test.tsx Outdated Show resolved Hide resolved

cnairiwttj reviewed May 24, 2022

View reviewed changes

RobelTekle added 3 commits May 24, 2022 17:57

fix: typo in test

e3ac030

fix: select use isDisabled prop instead of $disabled

d5111da

fix: type mismatch between onChange argument and SelectValue

c5b0159

cnairiwttj approved these changes May 25, 2022

View reviewed changes

theo-mesnil approved these changes May 25, 2022

View reviewed changes

theo-mesnil merged commit 56ebc97 into master May 25, 2022

theo-mesnil deleted the feat-select-disabled-options branch May 25, 2022 16:05

Provide feedback