fix: drawer trigger "as component" props #2087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #2083
The
Drawer.Trigger
throw errors when you add props of the "as" component:Here, the prop "variant" will throw an error, if you remove it, it works.
This is because the
Drawer.Trigger
component doesn't use our customforwardRef
type (this type inject props of the as component in the current component, here add the props of theButton
in theDrawer.Trigger
)