Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add X icon #2329

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat: add X icon #2329

merged 1 commit into from
Oct 10, 2023

Conversation

theo-mesnil
Copy link
Contributor

Fixes #2321

@theo-mesnil theo-mesnil requested review from a team as code owners October 9, 2023 09:17
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

👀 Visit Preview

mleralec
mleralec approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@mleralec mleralec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the legacy twitter icon? 🤔

@theo-mesnil
Copy link
Contributor Author

theo-mesnil commented Oct 9, 2023 •
edited

Should we keep the legacy twitter icon? 🤔

Yes, i just removed from examples but is still on the icons, we dont removed it @mleralec

@theo-mesnil theo-mesnil merged commit 2211ba0 into master Oct 10, 2023
9 checks passed
@theo-mesnil theo-mesnil deleted the feat-x-icon branch October 10, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mleralec mleralec mleralec approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Twitter/X icon
2 participants
@theo-mesnil @mleralec