Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popovers - fix FocusTrap and close functionality #58

Closed
KStClaire opened this issue Jun 28, 2017 · 0 comments
Closed

Popovers - fix FocusTrap and close functionality #58

KStClaire opened this issue Jun 28, 2017 · 0 comments

Comments

@KStClaire
Copy link
Collaborator

Currently, when a Popover contains a form element, the Popover will appear but never properly close. With the recent addition of the close button (#57) to non-form popovers, we need to extend the functioning close button to form popovers as well.

Some complications stemming from FocusTrap:

  • Currently only surrounds the popover's body content, which leaves the close button out of reachable focus. It's the same when trying to click outside of the popover.
  • FocusTrap cannot currently wrap Popover either, as this causes numerous breaks in both styling and popover function.

We need to update FocusTrap and/or PopoverTrigger to allow for the close button to be focusable/clickable.

@Darrken Darrken mentioned this issue Oct 18, 2017
@Darrken Darrken closed this as completed Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants