Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover Cleanup #86

Merged
merged 6 commits into from
Nov 1, 2017
Merged

Popover Cleanup #86

merged 6 commits into from
Nov 1, 2017

Conversation

Darrken
Copy link
Collaborator

@Darrken Darrken commented Oct 16, 2017 •
edited
Loading

Re-simplified popover (removed explicit support for forms), removed focus trap.
Addresses #60, #58

@Darrken Darrken requested a review from aabenoja October 16, 2017 16:13
mike-schenk
mike-schenk approved these changes Oct 31, 2017
View reviewed changes
Copy link
Collaborator

@mike-schenk mike-schenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Note the backward-incompatible props change in PopoverTrigger from shouldDisplayPopover to showPopover and the removal of containsFormElement

@Darrken
Merge branch 'master' into popover-fixes
fc907be 
# Conflicts:
#	package.json
#	src/components/patterns/datepicker-textbox/DatePickerTextbox.js
@Darrken
6.0.0
f23efb6
@Darrken
updated to v6, docs
e38782e
@mike-schenk mike-schenk merged commit db8001b into WTW-IM:master Nov 1, 2017
@Darrken Darrken deleted the popover-fixes branch December 12, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-schenk mike-schenk mike-schenk approved these changes

@aabenoja aabenoja Awaiting requested review from aabenoja

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darrken @mike-schenk