This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Yapi.py configuration setup #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wabri
added
enhancement
Closed
|
I dont get where is the error, this is my output: Why travis throw error on this? |
|
Solved problem with moving object help and options inside method |
|
Works only in python3.x |
IanDuncanT
reviewed
Jan 9, 2019
| @@ -15,6 +15,6 @@ def runScript(path_to_file): | |||
| bashCommand = bashCommand.replace("\n", " ; ") | |||
| output = subprocess.call( | |||
| bashCommand, stderr=subprocess.STDOUT, shell=True) | |||
| return output | |||
| return "Package installed correctly" | |||
There was a problem hiding this comment.
Only return that if output == 0. If output is 0, then it is correct, otherwise there was an error.
IanDuncanT
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
Closes #66