-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of EDMC's systems.p file (and others) #5
Comments
This is actually fortuitous timing! Thanks for the heads up. The current implementation is a direct clone of how the EDDB plugin used to do it, because I couldn't figure out another way back when I first set it up. I was already implementing a fix for this relating to #4 , and I'm just starting a week off so I'm sitting down to finish it right now :) |
Fixed as of latest release. |
EDMC 5.0.0 is out with this removal. We have one user reporting the issue, but I don't know if they're using the latest version. Log excerpt is:
|
Hi, I am that user. Thanks @Athanasius for identifying the actual issue. |
Apologies @DlljsCodes @Athanasius I saw this issue when you first commented and pushed a fix out almost immediately, it's just that I forgot to reopen and close the issue and didn't reference it anywhere in the rush to push the next fix. Somehow one affected file didn't get updated on GitHub when I did the original fix. See the latest release: https://github.com/WaferMouse/L3-37/releases/tag/110 |
Thanks, I've updated our Known Issues to reflect this (keeping the entry now with the link to v110). |
EDMC itself no longer makes use of the systems.p file shipped with it. At some future date it might not be shipped any more.
You appear to be using it (and stations.p) in the same manner the core EDDB plugin used to, i.e. to do System Name to EDDB ID lookups for the purpose of constructing EDDB URLs.
themroc kindly added some extra URL schemes to allow for both game system name and systemaddress/id64 lookup of systems, e.g.:
You should probably look into adjusting your code to no longer rely on any extra files shipped with EDMC, including, but not necessarily limited to:
commodity.csv
,rare_commodity.csv
,modules.p
,ships.p
,systems.p
,stations.p
. Although it's only systems.p and stations.p that are no longer used by EDMC itself at this time, the others really are only for internal use and any third-party use of them risks that breaking if we ever change their format.The text was updated successfully, but these errors were encountered: