Allow impersonation with spring #309
Conversation
|
Can you squash the formatting change, add some unit tests, and configuration to use this in one of our samples? Sent from Outlook Mobile On Sun, Dec 27, 2015 at 6:12 AM -0800, "Sergey Podolsky" notifications@github.com wrote: You can view, comment on, or merge this pull request online at: -- Commit Summary --
-- File Changes -- -- Patch Links -- https://github.com/dblock/waffle/pull/309.patch Reply to this email directly or view it on GitHub: |
| @@ -59,6 +61,9 @@ | |||
| /** The allow guest login. */ | |||
| private boolean allowGuestLogin = true; | |||
|
|
|||
| /** The impersonate. */ | |||
| private boolean impersonate; | |||
|
👍 Also update CHANGELOG. |
|
Done. |
| @@ -18,3 +18,4 @@ Waffle.sln.cache | |||
| Waffle.suo | |||
| *.csproj.user | |||
| .tern-project | |||
| *.iml | |||
There was a problem hiding this comment.
a module file created by IntelliJ IDEA
There was a problem hiding this comment.
I realize a comment was made to explicitly set impersonate to false. Jvm does that by default so I'd remove that. I'll get a better overall look tonight.
Sent from Outlook Mobile
On Wed, Dec 30, 2015 at 4:23 AM -0800, "Sergey Podolsky" notifications@github.com wrote:
@@ -18,3 +18,4 @@ Waffle.sln.cache
Waffle.suo
.csproj.user
.tern-project
+.iml
a module file created by IntelliJ IDEA
Reply to this email directly or view it on GitHub:
https://github.com/dblock/waffle/pull/309/files#r48601291
|
Squash your commits please. |
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| * Rework .net build to be mostly automatic using nuget | |||
| * Change .net target to more modern .net 4.0 framework | |||
| * [#309](https://github.com/dblock/waffle/pull/309): Added impersonation support on spring-security filters. | |||
There was a problem hiding this comment.
You should add your Github username. Thanks for contributing!
|
ok - here is what you need to do. In order to properly squash things, you will need to perform interactive rebase (git rebase -i HEAD When you get that completed, perform a rewrite using plus operator -> git push origin +master That will have this come in much cleaner to the master. Only other note is to use assertj instead of hamcrest matchers. I'm not sure if we have assertj in waffle at the moment but if we don't, just add it in the parent near where junit is pulled in. As soon as that is completed, I'll pull this in. Question for you...when this comes in where you looking for a time table for a release? I really don't have much more to add at this time. We have one other pull request outstanding but waiting on user to get back with us in performing some of the same things you just did. I'd like to get his changes as well. However, if you are wanting fairly fast turn around and he isn't responding, I'll move forwards. If you are willing to wait, I'll try to get his response or ultimately I'll address his changes directly so we can close that out. Anyway, thanks for the changes. I can see real value in this now with setup I use at my day job. |
|
This is not really urgent for me, so I am happy to wait as much as needed. Anyway, I will be on vacation till 11 Jan, so will address all your suggestions as soon as I come back and when I have some spare time. |
|
Sounds good. Enjoy your vacation Sent from Outlook Mobile On Fri, Jan 1, 2016 at 1:27 PM -0800, "Sergey Podolsky" notifications@github.com wrote: This is not really urgent for me, so I am happy to wait as much as needed. Anyway, I will be on vacation till 11 Jan, so will address all your suggestions as soon as I come back and when I have some spare time. Reply to this email directly or view it on GitHub: |
|
@sergey-podolsky When you get some time, if you want to button this guy up, I'll pull it in. |
sergey-podolsky
force-pushed
the
master
branch
from
ead6883
to
fbc311a
Compare
|
|
thanks @sergey-podolsky |
Allow impersonation with spring
No description provided.