Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new stable_fit3 in linemin #317

Merged
merged 3 commits into from
Sep 18, 2021
Merged

use new stable_fit3 in linemin #317

merged 3 commits into from
Sep 18, 2021

Conversation

willwheelera
Copy link
Collaborator

linemin was using a fit procedure that sometimes made poor moves. This is improved by two changes:

  1. include the current parameter point in the list of correlated samples
  2. if the proposed move is higher than the minimum test point, use the minimum test point instead.

lkwagner
lkwagner reviewed Sep 17, 2021
View reviewed changes
pyqmc/linemin.py Outdated Show resolved Hide resolved
@lkwagner lkwagner merged commit 91cec4e into WagnerGroup:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkwagner lkwagner lkwagner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willwheelera @lkwagner